Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel named "." cannot be joined #34168

Open
Gummikavalier opened this issue Dec 12, 2024 · 4 comments
Open

Channel named "." cannot be joined #34168

Gummikavalier opened this issue Dec 12, 2024 · 4 comments
Labels
Tasked Added to the internal issue tracking

Comments

@Gummikavalier
Copy link

Description:

Channel called . can be created but it cannot be joined or returned after navigating away from it.

Just a stupid issue we encountered, but nevertheless it is best to report it. It might indicate some other issue with escaping channel names etc.

Steps to reproduce:

  1. Create a public channel called . with web client
  2. Search for the channel with another user and try to join the channel

Expected behavior:

You can join the channel as usual

Actual behavior:

Screenshot from 2024-12-12 19-03-19

In the url-bar the channel path shows as /channel/ and not /channel/.

Typing in the correct url does not have any effect, as the address turns into /channel/ again.

Server Setup Information:

  • Version of Rocket.Chat Server: 7.1.0
  • License Type: Enterprise
  • Number of Users: 500+
  • Operating System: RHEL8
  • Deployment Method: tar
  • Number of Running Instances: 4
  • DB Replicaset Oplog: Yes
  • NodeJS Version: 20.18.0
  • MongoDB Version: 6.0

Client Setup Information

  • Desktop App or Browser Version: Any browser
@thepiyush-303
Copy link
Contributor

I believe room names containing special characters, such as (.), should not be allowed.

@reetp
Copy link

reetp commented Dec 13, 2024

This will be one for the internal team.

I will refer it immediately.

@reetp reetp added the Tasked Added to the internal issue tracking label Dec 13, 2024
@darshanlahamage
Copy link

Yes, the issue is correct. I rechecked it.
we can create this channel, but even admin cannot open it. Other user can leave it but not open it.
The channel . appears in the list, and backend operations like leaving the channel work, suggesting the database recognizes it
Clicking on the channel results in Page not found affecting both admins and users.
Likely cause: a routing issue where . is misinterpreted as a relative path in URLs or a validation gap allowing invalid channel names.

@reetp
Copy link

reetp commented Dec 14, 2024

Yes, the issue is correct. I rechecked it.

I know hence:

This will be one for the internal team.
I will refer it immediately.

No further action required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tasked Added to the internal issue tracking
Projects
None yet
Development

No branches or pull requests

5 participants
@reetp @Gummikavalier @darshanlahamage @thepiyush-303 and others