Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: BlockQuote Markdown is not rendering properly #675

Open
devanshkansagra opened this issue Dec 1, 2024 · 2 comments · May be fixed by #676
Open

Bug: BlockQuote Markdown is not rendering properly #675

devanshkansagra opened this issue Dec 1, 2024 · 2 comments · May be fixed by #676
Labels
bug Something isn't working

Comments

@devanshkansagra
Copy link
Contributor

devanshkansagra commented Dec 1, 2024

Description:

If you want to quote a text consisting of multiple paragraphs (that is, sentences delimited by empty lines), the quoted lines do not add up into a singular quote. Rather the quoted empty line[s] shows the > character and it renders the whole thing as multiple separate quotes.

Steps to reproduce:

Type in message box

> I will not use abbrev.
>
> I will not use abbrev.
>
> I will not use abbrev.

Expected behavior:

I'd rather expect to get a singular blockquote and no > characters shown.

Actual behavior:

image

@devanshkansagra devanshkansagra added the bug Something isn't working label Dec 1, 2024
@devanshkansagra devanshkansagra linked a pull request Dec 1, 2024 that will close this issue
@abirc8010
Copy link
Contributor

Hey @devanshkansagra , as far as I know, quoting a message uses a separate quote functionality tied to each message, and Markdown like '>' isn't used. So, it would render as plain text. Could you please clarify if you're referring to something else?"

@devanshkansagra
Copy link
Contributor Author

Hey @abirc8010, thanks for asking. The quoting you mean is the replying of the message. and this quoting is refered to markdown. if you check the github also, and type the message like I mentioned in the issue it will be quoted. So if you write single message like this "> Hii" it will be quoted. but there was inconsitency in terms of multiple messages. so I fixed this. you said that it renders as a plain text, I will add a border to the box to differentiate this as a quoted message. You can check this issue 33493 on RocketChat main repo.

@devanshkansagra devanshkansagra changed the title Bug: Quote Markdown is not rendering properly Bug: BlockQuote Markdown is not rendering properly Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants