Skip to content

Commit e971732

Browse files
committed
Finish reenabling action capabilities tests
1 parent 1f870c0 commit e971732

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

rosbridge_library/test/capabilities/test_action_capabilities.py

+2-5
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import rclpy
88
from action_msgs.msg import GoalStatus
99
from example_interfaces.action._fibonacci import Fibonacci_FeedbackMessage
10-
from rclpy.executors import SingleThreadedExecutor
10+
from rclpy.executors import MultiThreadedExecutor
1111
from rclpy.node import Node
1212
from rclpy.qos import DurabilityPolicy, QoSProfile, ReliabilityPolicy
1313
from rosbridge_library.capabilities.action_feedback import ActionFeedback
@@ -25,7 +25,7 @@
2525
class TestActionCapabilities(unittest.TestCase):
2626
def setUp(self):
2727
rclpy.init()
28-
self.executor = SingleThreadedExecutor()
28+
self.executor = MultiThreadedExecutor()
2929
self.node = Node("test_action_capabilities")
3030
self.executor.add_node(self.node)
3131

@@ -295,7 +295,6 @@ def test_cancel_advertised_action(self):
295295
self.assertEqual(self.received_message["values"]["sequence"], [])
296296
self.assertEqual(self.received_message["status"], GoalStatus.STATUS_CANCELED)
297297

298-
@unittest.skip("Currently raises an exception not catchable by unittest, need to fix this")
299298
def test_unadvertise_action(self):
300299
# Advertise the action
301300
action_path = "/fibonacci_action_4"
@@ -340,8 +339,6 @@ def test_unadvertise_action(self):
340339
self.assertTrue("id" in self.received_message)
341340

342341
# Now unadvertise the action
343-
# TODO: This raises an exception, likely because of the following rclpy issue:
344-
# https://github.com/ros2/rclpy/issues/1098
345342
unadvertise_msg = loads(dumps({"op": "unadvertise_action", "action": action_path}))
346343
self.received_message = None
347344
self.unadvertise.unadvertise_action(unadvertise_msg)

0 commit comments

Comments
 (0)