Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gymnasium API update #38

Open
smorad opened this issue Jan 26, 2023 · 2 comments
Open

Gymnasium API update #38

smorad opened this issue Jan 26, 2023 · 2 comments

Comments

@smorad
Copy link

smorad commented Jan 26, 2023

Will gymnax update their API in-line with gymnasium? Namely the recent breaking change in gym/gymnasium where step returns terminated, truncated instead of done?

@wookayin
Copy link

+1

The use of gym in this package is optional, and it could be replaced by import gymnasium as gym and as a fallback to gym. The package itself should not depend on gym.

@YannBerthelot
Copy link

Hi,

I would like to bring this subject back up as it is important.

Is there any plan to switch the current gymnax API (that returns done) to the gymnasium API (the returns terminatedand truncated) ?

I know that gymnax doesn't rely on gym to function, I'm talking about the return of the gymnax environments themselves.

As to why it's important to allow for the distinction between terminatedand truncated, here is a nice explication from gymnasium : https://farama.org/Gymnasium-Terminated-Truncated-Step-API.

If you'd prefer I can write the PR myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants