Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trusted certificate to allow downloads from motherless (fixes issue #2009) #2012

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

occipita
Copy link

@occipita occipita commented Jan 4, 2023

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

Description

Added a certificate store that is based on the one from OpenJDK 18 with the "GoGetSSL RSA DV CA" certificate added.

Added code in Utils class to load trust stores (based on code found at https://stackoverflow.com/a/10077862/20145163)

Modified App.main to load the certificate store

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).

     (although I note that there are a number of test failures, these seem to exist in the master branch already)
    
  • I've verified that this change works as intended.

    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

Added a certificate store that is based on the one from OpenJDK 18 with
the "GoGetSSL RSA DV CA" certificate added.

Added code in Utils class to load trust stores (based on code found at
https://stackoverflow.com/a/10077862/20145163)

Modified App.main to load the certificate store
@soloturn
Copy link
Contributor

soloturn commented Jun 10, 2023

@occipita woud you mind to create this on https://github.com/ripmeapp2/ripme ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSL Certificate not being found.
2 participants