Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons packaging: lacking viewBox and hardcoded fill color #45

Open
cyyynthia opened this issue Jun 3, 2024 · 0 comments
Open

Icons packaging: lacking viewBox and hardcoded fill color #45

cyyynthia opened this issue Jun 3, 2024 · 0 comments

Comments

@cyyynthia
Copy link

Hi!

First off thanks for your hard work building this cool icon pack :D - While adding it to my project, I noticed 2 problems that makes using them a bit annoying/difficult:

  • They lack viewBox="0 0 24 24", making browsers misbehave when rendering them
  • The use of a set color is always a bit of a bummer, it's always easier when icons support currentColor out of the box for use on the web

In my case I use https://github.com/cyyynthia/vite-plugin-magical-svg which generates a spritesheet and references symbols with use. It'd be great if the icons could be behaving nicely for these use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant