-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed the structure to allow for running it locally #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works fine, i'm okay with the tasks
in the backend folder, not sure about the src
.
cc @amine4567
Alternatively to the removing of src folder, we could add the following lines to the tasks.py to help with the importing:
This kinda feels a bit spaghetti though. |
I am not a fan of removing the The best practice in my opinion is to set the PYTHONPATH with the absolute path to the Are you familiar with For example:
|
If it's okay with everyone, I could update the README with instructions on how to use virtualenvs |
I dont think removing src from the backend implies the removing of the src folder in the frontend. I think the way I have provided is a decent enough way to do it and it keeps the barrier for entry into the development nice and low which to me is a major advantage considering the difference in experience in our team. If there is a good reason to keep the src folder then im fine to keep it but could you please do the setup for it then and test whether it works. |
Okay, if it makes it easier to dev for everybody else, I am good with the PR |
Due to modules and python paths, I changed some file locations and changed the references accordingly so its easier to run the flask stuff locally.