Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WebDriverNavigation to provide WebDriverWrapper navigation #9

Open
kgress opened this issue Mar 22, 2019 · 0 comments
Open

Update WebDriverNavigation to provide WebDriverWrapper navigation #9

kgress opened this issue Mar 22, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@kgress
Copy link
Contributor

kgress commented Mar 22, 2019

Summary

With separation of concerns in mind, we should move the navigate method from the WebDriverWrapper to the WebDriverNavigation method. Inherently, I think this makes the most sense as the WebDriverNavigation is supposed to be responsible only for anything navigation related.

    /**
     * Navigate to a specified URL
     *
     * @return as a {@link Navigation}
     */
    public Navigation navigate() {
        return this.driver.navigate();
    }

We should also think about moving anything else navigation related outside of the navigation method.

A/C

  • Move the navigate method from the WebDriverWrapper to WebDriverNavigation
  • Look into moving any other navigation related methods to WebDriverNavigation where it won't impede the ScaffoldBaseTest and any implementing BaseTest file from implementing projects
@kgress kgress added the enhancement New feature or request label Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant