Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate the need for TestContextSetting #5

Open
kgress opened this issue Mar 22, 2019 · 0 comments
Open

Investigate the need for TestContextSetting #5

kgress opened this issue Mar 22, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@kgress
Copy link
Contributor

kgress commented Mar 22, 2019

Summary

The TestContextSetting interface contains a collection of constant values that are currently being used along with the BaseTestContext singleton for adding and getting settings to the WebDriverContext.

Over half of these are not being used:

  • PROXY_MANAGER
  • PROXY_ASSIGNER
  • QUEUE_HOST
  • QUEUE_NAME
  • TEST_APPLICATION_CONTEXT

We should take a look and see if these values are required. Even further, we should determine if the TestContextSetting is necessary at all.

A/C

  • Investigate whether or not the TestContextSetting interface is required
  • After determination, commit changes and submit PR if a code change is required
@kgress kgress added the enhancement New feature or request label Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kgress