Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AbstractWebElement to provide all features from WebElement #16

Open
kgress opened this issue Apr 15, 2019 · 0 comments
Open

Update AbstractWebElement to provide all features from WebElement #16

kgress opened this issue Apr 15, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kgress
Copy link
Contributor

kgress commented Apr 15, 2019

Summary

Currently, the AbstractWebElement class implements a Scaffold interface called BaseWebElement. Right now, this interface is supposed to be a clone of the WebElement, from Selenium, but uses our strongly typed elements. It also protects the codebase from any major changes to the Selenium API.

However, there are currently some features in the BaseWebElement that are missing from the WebElement interface. This ticket is to update this class and interface to accurately clone the WebElement. For example, the isSelected() method is not being used.

We should make the current public getWebElement() method private and either rename this method or the existing protected getWebElement method to give us a better idea on what is going on.

Also, keep in mind that we have an AbstractClickable class that is used by elements such as ButtonWebElement. We should still ensure that we're encapsulating actions for elements correctly.

A/C

  • Scaffold's BaseWebElement should have all of the same functionality from WebElement provided
  • Scaffold should still ensure proper encapsulation by providing methods like click() in the AbstractClickable class.
  • We should rename the getWebElement() methods to accurately reflect the actions they are performing and also change their access accordingly.
@kgress kgress added enhancement New feature or request good first issue Good for newcomers labels Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant