Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug interface commands "force_open" and "force_off" are not working #1332

Open
martukas opened this issue Apr 4, 2023 · 0 comments
Open
Assignees
Labels
Bug Something isn't working Software Umbrella: GUI, Controller or CI

Comments

@martukas
Copy link
Member

martukas commented Apr 4, 2023

Current behaviour/situation

[sn:e1] set force_off
usage: debug_cli.py [-h] var data [data ...]
Encountered a parse error: debug_cli.py: error: the following arguments are required: data

[sn:e1] set force_open
usage: debug_cli.py [-h] var data [data ...]
Encountered a parse error: debug_cli.py: error: the following arguments are required: data

Expected state/behaviour
These commands should run exactly as written.

How do you know it is wrong
These commands do not require an additional parameter, and they used to work prior to #1290

Starting points
You can compare the code for the do_set function in the above-mentioned PR to see what the logic was prior to the changes that broke this functionality. The way the parser is set up for this sub-command does not respect the original logic that makes the data parameter optional.

@martukas martukas added Bug Something isn't working Software Umbrella: GUI, Controller or CI labels Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Software Umbrella: GUI, Controller or CI
Projects
None yet
Development

No branches or pull requests

2 participants