Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of Nanopb source files #1301

Open
martukas opened this issue Aug 9, 2022 · 1 comment
Open

Get rid of Nanopb source files #1301

martukas opened this issue Aug 9, 2022 · 1 comment
Labels
Controller code hardware controller project Needs help Jump in on these bugs! (Often good for newcomers) Software Umbrella: GUI, Controller or CI
Milestone
v0.4 software pre...

Comments

@martukas
Copy link
Member

martukas commented Aug 9, 2022 •
edited
Loading

Under software/common/third_party/nanopb we have some code that was copy-pasted from another repository. We will likely not invest in testing it. It is only indirectly used by generated code.

It should be possible to get rid of this code because there are packages for it for both PlatformIO and Conan, which should solve the controller's and GUI's needs respectively. How exactly this magic happens is not clear, but some leads were established in #1299 and this task might also dovetail with #1300 .

https://github.com/nanopb/nanopb

Worst case, bring it in as a git submodule...
@martukas martukas added Controller code hardware controller project Software Umbrella: GUI, Controller or CI labels Aug 9, 2022
@martukas martukas added the Needs help Jump in on these bugs! (Often good for newcomers) label Aug 9, 2022
@martukas
Copy link
Member Author

pio was not fetching the library
Related correspondents with maintainers:
https://community.platformio.org/t/failing-to-include-nanopb-libdep/29157

martukas added a commit that referenced this issue Apr 4, 2023
@martukas
nanopb brought in as pio package; updates #1301
f7d6198
martukas added a commit that referenced this issue Apr 4, 2023
@martukas
gui run does not need to generate protocols; updates #1301
f1cefa8
martukas added a commit that referenced this issue Apr 11, 2023
@martukas
nanopb brought in as pio package; updates #1301
5fab44e
martukas added a commit that referenced this issue Apr 11, 2023
@martukas
gui run does not need to generate protocols; updates #1301
0669c1b
martukas added a commit that referenced this issue Apr 11, 2023
@martukas
Nanopb libs brought in as platformio package (#1333)
b378644 
* nanopb brought in as pio package; updates #1301

* gui run does not need to generate protocols; updates #1301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Controller code hardware controller project Needs help Jump in on these bugs! (Often good for newcomers) Software Umbrella: GUI, Controller or CI
Projects
None yet
Milestone
v0.4 software pre-integration (FOCUS ...
Development

No branches or pull requests
1 participant
@martukas