Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAL refactoring: better callbacks #1294

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

martukas
Copy link
Member

@martukas martukas commented Jul 31, 2022

Closes #1293

Self-review checklist:

  • Self-review: looked through the Files changed tab, browsed repository in branch
  • Documentation updated - reflects changes in code, electrical or mechanical design
  • Documentation and graphics follow the documentation style guide
  • New content is linked, easily discoverable, does not require too many clicks
  • Follows other relevant parts of contributor wiki
  • PR has a descriptive name
  • Tagged relevant reviewers

Software only:

  • Follows our code style
  • Commented code, particularly in hard-to-understand areas
  • All tests pass - new and old, locally and on CI
  • No new warnings or static check failures
  • Tests that prove fix is effective or new feature works
  • Manual tests are explained, with instructions for reproducing them

@martukas martukas changed the title Issue 1293 better callbacks HAL refactoring: better callbacks Jul 31, 2022
@martukas martukas mentioned this pull request Jul 31, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HAL refactoring: better callbacks
1 participant