Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users when they use unsupported standard library imports #42

Open
rosieyohannan opened this issue Nov 1, 2018 · 1 comment
Open

Comments

@rosieyohannan
Copy link
Contributor

Can offer our targeted versions if relevant.

@pwaller
Copy link
Contributor

pwaller commented Nov 5, 2018

This shouldn't be too hard to implement in some ways, but is a part of a broader story of how to pass errors out to users, and how we're going to make reco check work.

In terms of how the feature might look, at the moment importing any standard library package is likely to be problematic due to our general lack of support for many language constructs. At least, at the moment I'm not particularly aware of any package that will work.

Another way to approach the issue might be to fail only when unsupported language features are actually used. That is, packages may contain many features, some of which might work and others not. So we need to decide whether to disable standard library packages wholesale or not.

@pwaller pwaller changed the title reco check should be aware of Go standard libraries and warn users appropriately if they have used something we don't support Warn users when they use unsupported standard library imports Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants