Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type mismatch in Subject against Observable detected by typescript 2.4.1 #2703

Closed
princemaple opened this issue Jun 28, 2017 · 3 comments
Closed

Comments

@princemaple
Copy link

When compiling with typescript 2.4.1, ts detects a type mismatch in Subject, extending the Observable class, that implements lift with a different method signature

RxJS version: 5.4.1

Code to reproduce: no code required

Expected behavior: types do match

Actual behavior: they don't

Additional information:

ERROR in /var/build/node_modules/rxjs/Subject.d.ts (16,22): Class 'Subject<T>' incorrectly extends base class 'Observable<T>'.
  Types of property 'lift' are incompatible.
    Type '<R>(operator: Operator<T, R>) => Observable<T>' is not assignable to type '<R>(operator: Operator<T, R>) => Observable<R>'.
      Type 'Observable<T>' is not assignable to type 'Observable<R>'.
        Type 'T' is not assignable to type 'R'.
@kwonoj
Copy link
Member

kwonoj commented Jun 28, 2017

dupe of #2699 , #2539, #2700 . #2701 #2702

@kwonoj kwonoj closed this as completed Jun 28, 2017
@princemaple
Copy link
Author

Ah, sorry. Thanks!

@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants