Skip to content
This repository has been archived by the owner on Apr 20, 2018. It is now read-only.

How am I supposed to import observable methods? #1553

Open
Sawtaytoes opened this issue Mar 23, 2018 · 0 comments
Open

How am I supposed to import observable methods? #1553

Sawtaytoes opened this issue Mar 23, 2018 · 0 comments

Comments

@Sawtaytoes
Copy link

I'm planning on using Webpack 4 in the future and am currently on Webpack 3. I'd like to get the full benefit of tree-shaking and want to make sure I'm importing rxjs correctly in my projects.

First, Webpack 4 has a thing that restricts you to either cjs, esm, or any import format. Webpack 3 does not have this, but does utilize tree-shaking where it exists.

When I do:

import { bindCallback } from 'rxjs/observable/bindCallback'

Am I using the cjs method and tree-shaking or will this automatically use esm if available?

From using other libraries like date-fns, I believe I have to do this instead:

import { bindCallback } from 'rxjs/_esm2015/observable/bindCallback'

Is my assumption correct, or do I keep calling imports like I've always been doing (the first example)?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant