Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design.mps.protan is missing from the masters #301

Open
rptb1 opened this issue Jan 3, 2025 · 1 comment
Open

design.mps.protan is missing from the masters #301

rptb1 opened this issue Jan 3, 2025 · 1 comment

Comments

@rptb1
Copy link
Member

rptb1 commented Jan 3, 2025

design.mps.protan is referenced at e.g.

mps/code/protan.c

Lines 45 to 48 in 9fd0577

/* ProtSync -- synchronize protection settings with hardware
*
* <design/protan#.fun.sync>.
*/
but is not present in https://github.com/Ravenbrook/mps/tree/master/design .

Discovered in conversation with @kbrowli about integrating MPS with Emacs on Cygwin.

@rptb1
Copy link
Member Author

rptb1 commented Jan 3, 2025

design/protan.txt was removed by @gareth-rees in Perforce changelist 187450 but this change did not update any references in protan.c .

The references need to be fixed up. I also suggest rewriting them in tag notation since that's more durable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant