update order pizza tests

Author: ancalita

actions/order_pizza.py

@@ -34,24 +34,6 @@ def run(self, dispatcher: CollectingDispatcher,
         return [SlotSet("membership_points", 150)]
 
 
-class ActionCorrectOrderDetails(Action):
-
-    def name(self) -> str:
-        return "action_ask_correct_order"
-
-    def run(self, dispatcher: CollectingDispatcher,
-            tracker: Tracker, domain: Dict[str, Any]):
-        dispatcher.utter_message(
-            text="I'm sorry about that. Let's correct your order. What would you like to change?",
-            buttons=[
-                {"title": "Pizza", "payload": "/SetSlots(pizza=null)"},
-                {"title": "Quantity", "payload": "/SetSlots(num_pizza=null)"},
-                {"title": "Address", "payload": "/SetSlots(address=null)"},
-            ]
-        )
-        return [SlotSet("confirmation_order", None), SlotSet("correct_order", True)]
-
-
 class ActionShowVacancies(Action):
 
     def name(self) -> str:
@@ -74,16 +56,3 @@ def run(self, dispatcher: CollectingDispatcher,
                 text="We don't have any vacancies at the moment in that department. Please check back later."
             )
         return []
-
-
-class ActionCorrectAddress(Action):
-
-        def name(self) -> str:
-            return "action_correct_address"
-
-        def run(self, dispatcher: CollectingDispatcher,
-                tracker: Tracker, domain: Dict[str, Any]):
-            dispatcher.utter_message(
-                text="I'm sorry about that. Let's correct your address. Please confirm your new address?"
-            )
-            return [SlotSet("address", None)]

data/flows/nlu.yml

@@ -165,28 +165,6 @@ nlu:
       - [3](number) pizzas
       - [4](number) pizzas
 
-  - intent: correct_order
-    examples: |
-      - I actually need to update my order.
-      - I made a mistake in my order.
-      - I need to change my order.
-      - I made a mistake in the delivery address.
-      - I need to update the delivery address.
-      - I made a mistake in the payment option.
-
-  - intent: correct_num_pizza
-    examples: |
-        - I actually want to order [2](number) pizzas.
-        - Need [10](number) pizzas now instead.
-        - I actually want to order [3](number) pizzas.
-        - I actually want to order [4](number) pizzas.
-        - I actually want to order [5](number) pizzas.
-        - I actually want to order [6](number) pizzas.
-        - I actually want to order [7](number) pizzas.
-        - I actually want to order [8](number) pizzas.
-        - I actually want to order [9](number) pizzas.
-        - I actually want to order [10](number) pizzas.
-
   - intent: correct_pizza_type
     examples: |
         - I actually want to order a [margherita](pizza_type) pizza.
@@ -202,19 +180,6 @@ nlu:
         - Actually, can i get a [diavola](pizza_type) instead.
         - Actually, can i get a [quattro formaggi](pizza_type) instead.
 
-  - intent: correct_address
-    examples: |
-      - I actually want to change the delivery address to 13 Pine Road.
-      - actually can i get the pizza delivered to 13 Pine Road.
-      - I made a mistake and need to update my delivery address first to 43 Elm Street.
-      - Send the pizza to 25 Maple Avenue instead.
-      - I need to update the delivery address to 59 Oak Drive.
-
-  - intent: correct_payment_option
-    examples: |
-      - Can I pay with credit card instead?
-      - I actually want to pay with membership points.
-
   - intent: affirm
     examples: |
       - Yes, that's correct.

data/flows/order_pizza.yml

@@ -63,28 +63,6 @@ flows:
                 next: END
           - else: END
 
-  correct_order:
-    name: correct_order
-    description: user wants to correct order details
-    nlu_trigger:
-    - intent:
-        name: correct_order
-        confidence_threshold: 0.5
-    steps:
-      - collect: correct_order
-      - call: fill_pizza_order
-
-  correct_address:
-    name: correct_address
-    description: user wants to correct the delivery address
-    nlu_trigger:
-    - intent:
-        name: correct_address
-        confidence_threshold: 0.7
-    steps:
-      - action: action_correct_address
-      - call: fill_pizza_order
-
   job_vacancies:
     name: job vacancies
     description: user asks for job vacancies

domain/flows/order_pizza.yml

@@ -6,11 +6,7 @@ intents:
   - inform_pizza_type
   - inform_address
   - inform_num_pizza
-  - correct_order
-  - correct_num_pizza
   - correct_pizza_type
-  - correct_address
-  - correct_payment_option
   - affirm
   - deny
 
@@ -24,6 +20,7 @@ slots:
     mappings:
         - type: from_entity
           entity: pizza_type
+        - type: from_llm
   num_pizza:
     type: float
     mappings:
@@ -32,19 +29,20 @@ slots:
           intent: inform_num_pizza
           conditions:
             - active_flow: fill_pizza_order
-        - type: from_entity
-          entity: number
-          intent: correct_num_pizza
+        - type: from_llm
+          allow_nlu_correction: true
           conditions:
-          - active_flow: fill_pizza_order
-          - active_flow: order_pizza
+            - active_flow: fill_pizza_order
+            - active_flow: order_pizza
   address:
     type: text
     mappings:
       - type: from_text
         intent: inform_address
         conditions:
           - active_flow: fill_pizza_order
+      - type: from_llm
+        allow_nlu_correction: true
   confirmation_order:
     type: bool
     mappings:

e2e_tests/passing/corrections/user_corrects_slot_with_nlu_based_mapping.yml

@@ -46,12 +46,11 @@ test_cases:
       - user: /SetSlots(confirmation_order=True)
       - utter: utter_ask_payment_option
       - user: wait, i meant to say the pizza should be delivered to 13 Pine Road.
-      - bot: "I'm sorry about that. Let's correct your address. Please confirm your new address?"
-      - utter: utter_ask_address
-      - user: 13 Pine Road
+      - bot: Would you like to change the address?
+      - user: /SetSlots(confirm_slot_correction=true)
+      - utter: utter_corrected_previous_input
       - utter: utter_confirm
       - user: /SetSlots(confirmation_order=True)
-      - utter: utter_flow_continue_interrupted
       - utter: utter_ask_payment_option
 
   - test_case: user_orders_pizza_stating_which_type_and_corrects_payment_option_later
@@ -72,7 +71,7 @@ test_cases:
       - utter: utter_corrected_previous_input
       - utter: utter_ask_card_details
 
-  - test_case: user_orders_pizza_stating_which_type_and_corrects_order_details_later
+  - test_case: user_orders_pizza_stating_which_type_and_corrects_address_mistake_later
     steps:
       - user: I would like to order a diavola pizza.
       - utter: utter_ask_num_pizza
@@ -83,12 +82,11 @@ test_cases:
       - user: /SetSlots(confirmation_order=True)
       - utter: utter_ask_payment_option
       - user: actually, i made a mistake and need to update my delivery address first.
-      - bot: "I'm sorry about that. Let's correct your order. What would you like to change?"
-        # TODO: ideal place to assert planned buttons feature in e2e testing
-      - user: /SetSlots(address=null)
+      - bot: Would you like to change the address?
+      - user: /SetSlots(confirm_slot_correction=true)
+      - utter: utter_corrected_previous_input
       - utter: utter_ask_address
-      - user: 3 Pine Road
+      - user: 31 Pine Road
       - utter: utter_confirm
       - user: /SetSlots(confirmation_order=True)
-      - utter: utter_flow_continue_interrupted
       - utter: utter_ask_payment_option

e2e_tests_with_assertions/passing/corrections/user_corrects_slot_with_nlu_based_mapping.yml

@@ -1,3 +1,6 @@
+metadata:
+  - duplicate_confirmation:
+      turn_idx: 2
 test_cases:
   - test_case: user_orders_pizza_stating_which_type_and_corrects_quantity_later
     steps:
@@ -120,21 +123,18 @@ test_cases:
                 utter_name: utter_ask_payment_option
       - user: wait, i meant to say the pizza should be delivered to 13 Pine Road.
         assertions:
+            - flow_started: pattern_correction
             - bot_uttered:
-                text_matches: "I'm sorry about that. Let's correct your address. Please confirm your new address?"
-            - slot_was_set:
-                - name: address
-                  value: null
-            - bot_uttered:
-                utter_name: utter_ask_address
-      - user: 13 Pine Road
+                utter_name: utter_ask_confirm_slot_correction
+      - user: /SetSlots(confirm_slot_correction=true)
         assertions:
             - slot_was_set:
                 - name: address
                   value: 13 Pine Road
             - bot_uttered:
                 utter_name: utter_confirm
       - user: /SetSlots(confirmation_order=True)
+        metadata: duplicate_confirmation
         assertions:
             - bot_uttered:
                 utter_name: utter_ask_payment_option
@@ -189,7 +189,7 @@ test_cases:
             - bot_uttered:
                 utter_name: utter_ask_card_details
 
-  - test_case: user_orders_pizza_stating_which_type_and_corrects_order_details_later
+  - test_case: user_orders_pizza_stating_which_type_and_corrects_generically_later
     steps:
       - user: I would like to order a diavola pizza.
         assertions:
@@ -218,17 +218,16 @@ test_cases:
                 utter_name: utter_ask_payment_option
       - user: actually, i made a mistake and need to update my delivery address first.
         assertions:
+            - flow_started: pattern_correction
             - bot_uttered:
-                text_matches: "I'm sorry about that. Let's correct your order. What would you like to change?"
-                buttons:
-                  - title: Pizza
-                    payload: /SetSlots(pizza=null)
-                  - title: Quantity
-                    payload: /SetSlots(num_pizza=null)
-                  - title: Address
-                    payload: /SetSlots(address=null)
-      - user: /SetSlots(address=null)
+                utter_name: utter_ask_confirm_slot_correction
+      - user: /SetSlots(confirm_slot_correction=true)
         assertions:
+            - slot_was_set:
+                - name: confirm_slot_correction
+                  value: true
+            - bot_uttered:
+                utter_name: utter_corrected_previous_input
             - bot_uttered:
                 utter_name: utter_ask_address
       - user: 3 Pine Road
@@ -239,6 +238,67 @@ test_cases:
             - bot_uttered:
                 utter_name: utter_confirm
       - user: /SetSlots(confirmation_order=True)
+        metadata: duplicate_confirmation
         assertions:
             - bot_uttered:
                 utter_name: utter_ask_payment_option
+
+  - test_case: user_orders_pizza_then_corrects_pizza_type_and_number_and_address
+    steps:
+      - user: I'd like to order some pizza.
+        assertions:
+            - bot_uttered:
+                utter_name: utter_ask_pizza
+      - user: Could I have a cappriciosa?
+        assertions:
+            - slot_was_set:
+                - name: pizza
+                  value: cappriciosa
+            - bot_uttered:
+                utter_name: utter_ask_num_pizza
+      - user: 3 please
+        assertions:
+            - slot_was_set:
+                - name: num_pizza
+                  value: 3
+            - bot_uttered:
+                utter_name: utter_ask_address
+      - user: wait can i actually just get 1 festa de carne pizza instead
+        assertions:
+            - flow_started: pattern_correction
+            - bot_uttered:
+                utter_name: utter_ask_confirm_slot_correction
+      - user: /SetSlots(confirm_slot_correction=true)
+        assertions:
+            - slot_was_set:
+                - name: pizza
+                  value: festa de carne
+            - slot_was_set:
+                - name: num_pizza
+                  value: 1
+            - bot_uttered:
+                utter_name: utter_corrected_previous_input
+            - bot_uttered:
+                utter_name: utter_ask_address
+      - user: 30 Pine Road
+        assertions:
+            - slot_was_set:
+                - name: address
+                  value: 30 Pine Road
+            - bot_uttered:
+                utter_name: utter_confirm
+      - user: oh I gave my work address, i actually want it delivered to my home at 13 Pine Road
+        assertions:
+            - flow_started: pattern_correction
+            - bot_uttered:
+                utter_name: utter_ask_confirm_slot_correction
+      - user: /SetSlots(confirm_slot_correction=true)
+        metadata: duplicate_confirmation
+        assertions:
+            - slot_was_set:
+                - name: address
+                  value: 13 Pine Road
+            - bot_uttered:
+                utter_name: utter_corrected_previous_input
+            - bot_uttered:
+                utter_name: utter_confirm

endpoints.yml

@@ -57,6 +57,8 @@ action_endpoint:
 #
 nlg:
   type: rephrase
+  llm:
+    model_group: openai-direct-gpt-4o
 
 # Run OTEL collector (via `otel-docker-compose.yml`), and uncomment this section, to send traces to it.
 # tracing:
@@ -94,4 +96,8 @@ model_groups:
         model: gpt-3.5-turbo-0125
         timeout: 7
         temperature: 0.0
-        top_p: 0.0
+        top_p: 0.0
+  - id: openai-direct-gpt-4o
+    models:
+      - provider: openai
+        model: gpt-4o