Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken CD workflow #60

Open
2 tasks
samsucik opened this issue Feb 14, 2022 · 2 comments
Open
2 tasks

Fix broken CD workflow #60

samsucik opened this issue Feb 14, 2022 · 2 comments

Comments

@samsucik
Copy link
Contributor

samsucik commented Feb 14, 2022

Recently, upon merging in a very innocent PR, the deploy step in the CD workflow failed. Even upon re-running it, it is still failing, see here. I think somebody from the Infra squad should look into this, don't think an Engine or AI Research person is equipped to handle it.

I should say that this does not impact the deployed version of Carbon Bot in any visible way (as far as I can see).

This also points to a broader issue -- one can't test the deploy step on a PR of this repo as the step only runs on main. That's rather unfortunate and should be improved in the future.

Definition of done:

  • investigate the issue and propose a solution
  • if the solution is extremely easy, also implement it and make sure the deploy step actually succeeds on main -- otherwise, create a separate issue
@samsucik
Copy link
Contributor Author

I'm dropping this into the Research inbox because our PM should look at this before we send it to Infra.

@TyDunn
Copy link

TyDunn commented Feb 17, 2022

@samsucik Moving this to Infra board

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants