You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just found a bug when using inputStream() on a user object.
MumbleClient.inputStreamForUser requires the session ID as well as streaming options, however, User.inputStream() only passes the session ID which causes a TypeError when setting the whisperId on the undefined options object.
Thats basically what @stanix fixed in stanix@0965ae7
If you're fine with it, I'll create a pull requests fixing this one as well as another one fixing the typescript definitions.
ppacher
changed the title
user.inputStream() failes with TypeError: cannot set whisperId of undefined
user.inputStream() fails with TypeError: cannot set whisperId of undefined
Sep 4, 2018
If you can get the typescript stuff to follow the JSDocs, that would be best. I haven't had any exposure to TypeScript so I don't really know the details of those bindings. As long as they need to be kept up to date manually I'm afraid they will become outdated whenever there are changes to the APIs.
ppacher
pushed a commit
to ppacher/node-mumble
that referenced
this issue
Sep 5, 2018
Hi,
I just found a bug when using inputStream() on a user object.
MumbleClient.inputStreamForUser
requires the session ID as well as streaming options, however,User.inputStream()
only passes the session ID which causes a TypeError when setting the whisperId on the undefined options object.See https://github.com/Rantanen/node-mumble/blob/master/lib/MumbleClient.js#L293
and https://github.com/Rantanen/node-mumble/blob/master/lib/User.js#L118 .
Btw, the typescript bindings are outdated. I'd be fine to provide updated ones or try to integrate TS definitions from JSDocs.
Cheers,
Patrick
The text was updated successfully, but these errors were encountered: