Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user.inputStream() fails with TypeError: cannot set whisperId of undefined #110

Open
ppacher opened this issue Sep 4, 2018 · 2 comments

Comments

@ppacher
Copy link

ppacher commented Sep 4, 2018

Hi,

I just found a bug when using inputStream() on a user object.

MumbleClient.inputStreamForUser requires the session ID as well as streaming options, however, User.inputStream() only passes the session ID which causes a TypeError when setting the whisperId on the undefined options object.

See https://github.com/Rantanen/node-mumble/blob/master/lib/MumbleClient.js#L293
and https://github.com/Rantanen/node-mumble/blob/master/lib/User.js#L118 .

Btw, the typescript bindings are outdated. I'd be fine to provide updated ones or try to integrate TS definitions from JSDocs.

Cheers,
Patrick

@ppacher
Copy link
Author

ppacher commented Sep 4, 2018

Thats basically what @stanix fixed in stanix@0965ae7
If you're fine with it, I'll create a pull requests fixing this one as well as another one fixing the typescript definitions.

@ppacher ppacher changed the title user.inputStream() failes with TypeError: cannot set whisperId of undefined user.inputStream() fails with TypeError: cannot set whisperId of undefined Sep 4, 2018
@Rantanen
Copy link
Owner

Rantanen commented Sep 4, 2018

Oh; Sure. That sounds great!

If you can get the typescript stuff to follow the JSDocs, that would be best. I haven't had any exposure to TypeScript so I don't really know the details of those bindings. As long as they need to be kept up to date manually I'm afraid they will become outdated whenever there are changes to the APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants