Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remnants of development left in release #37

Open
adriaandegroot opened this issue Sep 13, 2018 · 1 comment
Open

Remnants of development left in release #37

adriaandegroot opened this issue Sep 13, 2018 · 1 comment
Assignees
Milestone

Comments

@adriaandegroot
Copy link

A wild user appears! Filing an upstream bug, rather than a packaging bug in FreeBSD. In vzvol 0.7.0, near the top of the script is this:

vzvol_gitdir=$( find ./ -name "vzvol" | grep bin | sed 's/.\{10\}$//' )

Which, when I run vzvol --list to find what is out there, does a find in my cwd -- which is the top of 3 GiB of source checkouts :( There might even be a vzvol clone in there somewhere, but that's not what I'm waiting for.

@RainbowHackerHorse
Copy link
Owner

This isn't actually a development remnant; it's meant to search for a vzvol git directory if it's not using the standard install path.
I don't think anyone's using it in a non-standard way, however, and should change this to erroring out with a warning message if it can't find what its libraries.

@RainbowHackerHorse RainbowHackerHorse added this to the v0.7.1 milestone Nov 2, 2018
@RainbowHackerHorse RainbowHackerHorse self-assigned this Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants