Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can improve the while loop, but not sure is useful #118

Open
todo bot opened this issue Sep 14, 2021 · 0 comments
Open

can improve the while loop, but not sure is useful #118

todo bot opened this issue Sep 14, 2021 · 0 comments
Assignees
Labels
driver driver related refactor refactoring code, same functionality, but better code todo 🗒️

Comments

@todo
Copy link

todo bot commented Sep 14, 2021

can compute the size to read from the next closest offsets need to be searched and then subtract the 2 start end string constant function. besides after read the asm code, is useless as need a asm 8086 interpreter to understand and convert it.


https://github.com/Raffaello/sdl2-sonic-drivers/blob/d3ce8bc24ed3c8c6a11e98f055a45fb9e1bd5e5f/sdl2-sonic-drivers/src/files/miles/AILDriverFile.cpp#L101-L106


This issue was generated by todo based on a TODO comment in d3ce8bc when #117 was merged. cc @Raffaello.
@todo todo bot added the todo 🗒️ label Sep 14, 2021
@todo todo bot assigned Raffaello Sep 14, 2021
@Raffaello Raffaello added the refactor refactoring code, same functionality, but better code label Sep 14, 2021
@Raffaello Raffaello added the driver driver related label Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
driver driver related refactor refactoring code, same functionality, but better code todo 🗒️
Projects
None yet
Development

No branches or pull requests

1 participant