-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge back 6.3 hotfixes #588
Merged
stanleytsang-amd
merged 15 commits into
ROCm:develop
from
stanleytsang-amd:6.4-ver-update-and-mergeback
Nov 20, 2024
Merged
Merge back 6.3 hotfixes #588
stanleytsang-amd
merged 15 commits into
ROCm:develop
from
stanleytsang-amd:6.4-ver-update-and-mergeback
Nov 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Referencing or using code from some websites is prohibited in this repository. This change removes an informational reference in the comments.
Co-authored-by: Stanley Tsang <[email protected]> Co-authored-by: Eiden Yoshida <[email protected]>
* added hipFree to test_rocrand_cpp_basic * fixed memory leak for test_rocrand_config_dispatch * fixed a memory leak in test_utils * changed createGraph to createAndLaunchGraph, as well as fixed stream capture order * changed default boolean (kaunchGraph, sync) to be true in createAndLaunchGraph * added back missing end stream capture * reformated curlys for consistency * removed createAndLaunchGraph inside resetGraphHelper
Co-authored-by: Jeffrey Novotny <[email protected]>
Co-authored-by: Jeffrey Novotny <[email protected]>
[cherry pick 6.3] Include gfx12 and gfx1151 in default architecture list for rmake.py
stanleytsang-amd
requested review from
a team,
umfranzw,
RobsonRLemos and
lawruble13
as code owners
November 20, 2024 22:51
RobsonRLemos
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge back 6.3 hotfixes looks good.
NguyenNhuDi
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.