diff --git a/CMakeLists.txt b/CMakeLists.txt index 83e88331f..b4acfd4bb 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -101,7 +101,7 @@ if(GPU_TARGETS STREQUAL "all") ) else() rocm_check_target_ids(DEFAULT_AMDGPU_TARGETS - TARGETS "gfx803;gfx900:xnack-;gfx906:xnack-;gfx908:xnack-;gfx90a:xnack-;gfx90a:xnack+;gfx940;gfx941;gfx942;gfx1030;gfx1100;gfx1101;gfx1102;gfx1200;gfx1201" + TARGETS "gfx803;gfx900:xnack-;gfx906:xnack-;gfx908:xnack-;gfx90a:xnack-;gfx90a:xnack+;gfx940;gfx941;gfx942;gfx1030;gfx1100;gfx1101;gfx1102;gfx1200;gfx1201;gfx1151" ) endif() diff --git a/docs/conceptual/data-type-support.rst b/docs/api-reference/data-type-support.rst similarity index 99% rename from docs/conceptual/data-type-support.rst rename to docs/api-reference/data-type-support.rst index 619300306..faba618d8 100644 --- a/docs/conceptual/data-type-support.rst +++ b/docs/api-reference/data-type-support.rst @@ -4,7 +4,7 @@ .. _data-type-support: -Data type support +rocRAND data type support ****************************************** Host API diff --git a/docs/index.rst b/docs/index.rst index eba1fb946..a7eeddaf0 100644 --- a/docs/index.rst +++ b/docs/index.rst @@ -31,12 +31,13 @@ The documentation is structured as follows: .. grid-item-card:: Conceptual * :ref:`programmers-guide` - * :ref:`data-type-support` + * :ref:`curand-compatibility` * :ref:`dynamic-ordering-configuration` .. grid-item-card:: API reference + * :doc:`rocRAND data type support ` * :ref:`cpp-api` * :ref:`python-api` * :doc:`Fortran API reference ` diff --git a/docs/sphinx/_toc.yml.in b/docs/sphinx/_toc.yml.in index 11dd63904..c2fb9a9bb 100644 --- a/docs/sphinx/_toc.yml.in +++ b/docs/sphinx/_toc.yml.in @@ -8,11 +8,11 @@ subtrees: - caption: Conceptual entries: - file: conceptual/programmers-guide - - file: conceptual/data-type-support - file: conceptual/curand-compatibility - file: conceptual/dynamic_ordering_configuration - caption: API reference entries: + - file: api-reference/data-type-support - file: api-reference/cpp-api - file: api-reference/python-api - file: fortran-api-reference diff --git a/scripts/copyright-date/check-copyright.sh b/scripts/copyright-date/check-copyright.sh index 04d941b96..fccbdb9ac 100755 --- a/scripts/copyright-date/check-copyright.sh +++ b/scripts/copyright-date/check-copyright.sh @@ -61,7 +61,6 @@ if $forkdiff; then source_commit="remotes/$remote/HEAD" # don't use fork-point for finding fork point (lol) - # see: https://stackoverflow.com/a/53981615 diff_hash="$(git merge-base "$source_commit" "$branch")" fi diff --git a/test/internal/test_rocrand_config_dispatch.cpp b/test/internal/test_rocrand_config_dispatch.cpp index 1d1cda080..06bef1c4d 100644 --- a/test/internal/test_rocrand_config_dispatch.cpp +++ b/test/internal/test_rocrand_config_dispatch.cpp @@ -89,6 +89,8 @@ TEST(rocrand_config_dispatch_tests, host_matches_device) ASSERT_NE(host_arch, rocrand_impl::host::target_arch::invalid); ASSERT_EQ(host_arch, device_arch); + + HIP_CHECK(hipFree(device_arch_ptr)); } TEST(rocrand_config_dispatch_tests, parse_common_architectures) diff --git a/test/test_rocrand_cpp_basic.cpp b/test/test_rocrand_cpp_basic.cpp index 7ae31b386..d17a766de 100644 --- a/test/test_rocrand_cpp_basic.cpp +++ b/test/test_rocrand_cpp_basic.cpp @@ -84,8 +84,9 @@ TYPED_TEST(rocrand_cpp_basic_tests, move_construction) float actual; HIP_CHECK(hipMemcpy(&actual, d_data, sizeof(actual), hipMemcpyDeviceToHost)); - ASSERT_EQ(expected, actual); + + HIP_CHECK(hipFree(d_data)); } TYPED_TEST(rocrand_cpp_basic_tests, move_assignment) @@ -119,6 +120,7 @@ TYPED_TEST(rocrand_cpp_basic_tests, move_assignment) float actual; HIP_CHECK(hipMemcpy(&actual, d_data, sizeof(actual), hipMemcpyDeviceToHost)); - ASSERT_EQ(expected, actual); + + HIP_CHECK(hipFree(d_data)); } diff --git a/test/test_rocrand_hipgraphs.cpp b/test/test_rocrand_hipgraphs.cpp index 3b94186f6..912c99c55 100644 --- a/test/test_rocrand_hipgraphs.cpp +++ b/test/test_rocrand_hipgraphs.cpp @@ -34,34 +34,34 @@ void test_float(std::functiongraph)); + HIP_CHECK_NON_VOID(hipGraphExecDestroy(this->graph_instance)); + } + + inline void resetGraphHelper(hipStream_t& stream, const bool beginCapture=true) + { + // Destroy the old graph and instance + cleanupGraphHelper(); + + if(beginCapture) + startStreamCapture(stream); + } + + inline void launchGraphHelper(hipStream_t& stream,const bool sync=false) + { + HIP_CHECK_NON_VOID(hipGraphLaunch(this->graph_instance, stream)); + + // Optionally sync after the launch + if (sync) + HIP_CHECK_NON_VOID(hipStreamSynchronize(stream)); + } + }; } // end namespace test_utils #endif //ROCRAND_TEST_UTILS_HIPGRAPHS_HPP