Fixed memory leaks in rocrand_tests #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NguyenNhuDi
requested review from
stanleytsang-amd,
umfranzw,
RobsonRLemos and
lawruble13
as code owners
umfranzw
requested changes
Sep 26, 2024
umfranzw
requested changes
Oct 8, 2024
stanleytsang-amd
approved these changes
Oct 12, 2024
umfranzw
approved these changes
Oct 16, 2024
umfranzw
merged commit c1640d9
into
ROCm:release-staging/rocm-rel-6.3
23 of 24 checks passed
stanleytsang-amd
added a commit
that referenced
this pull request
Nov 20, 2024
* Remove website URL from comments (#542) Referencing or using code from some websites is prohibited in this repository. This change removes an informational reference in the comments. * Add gfx1151 target (#543) (#546) Co-authored-by: Stanley Tsang <[email protected]> Co-authored-by: Eiden Yoshida <[email protected]> * Move data type support file along with index and ToC changes (#548) (#549) * Convert change log to new format (#564) * Fixed memory leaks in rocrand_tests (#557) * added hipFree to test_rocrand_cpp_basic * fixed memory leak for test_rocrand_config_dispatch * fixed a memory leak in test_utils * changed createGraph to createAndLaunchGraph, as well as fixed stream capture order * changed default boolean (kaunchGraph, sync) to be true in createAndLaunchGraph * added back missing end stream capture * reformated curlys for consistency * removed createAndLaunchGraph inside resetGraphHelper * Update changelog release headers (#568) (#575) * Update changelog release headers * Small correction (cherry picked from commit c7da202) * Add readme and metadata info and clarify CUDA references (#567) (#576) (cherry picked from commit 81d9e58) * added gfx12 and gfx1151 to default gpu list * updated changelog * Update CHANGELOG.md Co-authored-by: Jeffrey Novotny <[email protected]> * Update CHANGELOG.md Co-authored-by: Jeffrey Novotny <[email protected]> * Remove gfx940,gfx941 targets (#580) * Remove unreleased --------- Co-authored-by: Wayne Franz <[email protected]> Co-authored-by: amd-garydeng <[email protected]> Co-authored-by: Eiden Yoshida <[email protected]> Co-authored-by: Jeffrey Novotny <[email protected]> Co-authored-by: Di Nguyen <[email protected]> Co-authored-by: Val Movsik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing hipFree calls to test_rocrand_config_dispatch and test_rocrand_cpp_basic. Fixed an issue where test_utils was calling an extra hipCreateGraph call causing a graph to be overwritten which led to a memory leak.