Enable and fix compiler warnings (#136)

Author: AryanSalmanpour

CMakeLists.txt

@@ -173,7 +173,7 @@ if(HIP_FOUND AND Libva_FOUND)
   # rocJPEG.so
   add_library(${PROJECT_NAME} SHARED ${SOURCES})
 
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=gnu++17")
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=gnu++17 -Wall")
   target_link_libraries(${PROJECT_NAME} ${LINK_LIBRARY_LIST})
 
   set_target_properties(${PROJECT_NAME} PROPERTIES POSITION_INDEPENDENT_CODE ON)

src/amd_detail/rocjpeg_api_trace.cpp

@@ -70,18 +70,14 @@ template <> struct dispatch_table_info<TYPE> { \
     static constexpr auto import_func = &ROCPROFILER_REGISTER_IMPORT_FUNC(NAME); \
 };
 
-constexpr auto ComputeTableSize(size_t num_funcs) {
-    return (num_funcs * sizeof(void*)) + sizeof(uint64_t);
-}
-
 ROCJPEG_DEFINE_DISPATCH_TABLE_INFO(RocJpegDispatchTable, rocjpeg)
 #endif
 
 template <typename Tp> void ToolInit(Tp* table) {
 #if ROCJPEG_ROCPROFILER_REGISTER > 0
     auto table_array = std::array<void*, 1>{static_cast<void*>(table)};
     auto lib_id = rocprofiler_register_library_indentifier_t{};
-    auto rocp_reg_status = rocprofiler_register_library_api_table(
+    rocprofiler_register_library_api_table(
         dispatch_table_info<Tp>::name, dispatch_table_info<Tp>::import_func,
         dispatch_table_info<Tp>::version, table_array.data(), table_array.size(), &lib_id);
 #else

src/rocjpeg_commons.h

@@ -64,15 +64,6 @@ THE SOFTWARE.
     }                                                                     \
 }
 
-static bool GetEnv(const char *name, char *value, size_t valueSize) {
-    const char *v = getenv(name);
-    if (v) {
-        strncpy(value, v, valueSize);
-        value[valueSize - 1] = 0;
-    }
-    return v ? true : false;
-}
-
 static inline int align(int value, int alignment) {
    return (value + alignment - 1) & ~(alignment - 1);
 }

src/rocjpeg_decoder.cpp

@@ -28,6 +28,9 @@ RocJpegDecoder::RocJpegDecoder(RocJpegBackend backend, int device_id) :
 RocJpegDecoder::~RocJpegDecoder() {
     if (hip_stream_) {
         hipError_t hip_status = hipStreamDestroy(hip_stream_);
+        if (hip_status != hipSuccess) {
+            ERR("ERROR: Failed to destroy the HIP stream!");
+        }
     }
 }
 
@@ -44,7 +47,6 @@ RocJpegDecoder::~RocJpegDecoder() {
  *         - ROCJPEG_STATUS_INVALID_PARAMETER if the requested device_id is not found.
  */
 RocJpegStatus RocJpegDecoder::InitHIP(int device_id) {
-    hipError_t hip_status = hipSuccess;
     CHECK_HIP(hipGetDeviceCount(&num_devices_));
     if (num_devices_ < 1) {
         ERR("ERROR: Failed to find any GPU!");
@@ -80,7 +82,7 @@ RocJpegStatus RocJpegDecoder::InitializeDecoder() {
     }
     if (backend_ == ROCJPEG_BACKEND_HARDWARE) {
         std::string gpu_uuid(hip_dev_prop_.uuid.bytes, sizeof(hip_dev_prop_.uuid.bytes));
-        rocjpeg_status = jpeg_vaapi_decoder_.InitializeDecoder(hip_dev_prop_.name, hip_dev_prop_.gcnArchName, device_id_, gpu_uuid);
+        rocjpeg_status = jpeg_vaapi_decoder_.InitializeDecoder(hip_dev_prop_.name, device_id_, gpu_uuid);
         if (rocjpeg_status != ROCJPEG_STATUS_SUCCESS) {
             ERR("ERROR: Failed to initialize the VA-API JPEG decoder!");
             return rocjpeg_status;
@@ -104,7 +106,6 @@ RocJpegStatus RocJpegDecoder::InitializeDecoder() {
  */
 RocJpegStatus RocJpegDecoder::Decode(RocJpegStreamHandle jpeg_stream_handle, const RocJpegDecodeParams *decode_params, RocJpegImage *destination) {
     std::lock_guard<std::mutex> lock(mutex_);
-    RocJpegStatus rocjpeg_status = ROCJPEG_STATUS_SUCCESS;
     if (jpeg_stream_handle == nullptr || decode_params == nullptr || destination == nullptr) {
         return ROCJPEG_STATUS_INVALID_PARAMETER;
     }

src/rocjpeg_hip_kernels.cpp

@@ -22,7 +22,7 @@ THE SOFTWARE.
 #include "rocjpeg_parser.h"
 
 RocJpegStreamParser::RocJpegStreamParser() : stream_{nullptr}, stream_end_{nullptr}, stream_length_{0},
-    jpeg_stream_parameters_{{}} {
+    jpeg_stream_parameters_{} {
 }
 
 RocJpegStreamParser::~RocJpegStreamParser() {
@@ -337,7 +337,7 @@ bool RocJpegStreamParser::ParseSOS() {
     jpeg_stream_parameters_.slice_parameter_buffer.num_components = num_components;
 
     stream_ += 3;
-    for (int32_t i = 0; i < num_components; i++) {
+    for (uint32_t i = 0; i < num_components; i++) {
         component_id = *stream_++;
         table = *stream_++;
         jpeg_stream_parameters_.slice_parameter_buffer.components[i].component_selector = component_id;

src/rocjpeg_parser.cpp

@@ -294,7 +294,7 @@ bool RocJpegVaapiMemoryPool::SetSurfaceAsIdle(VASurfaceID surface_id) {
  */
 RocJpegVappiDecoder::RocJpegVappiDecoder(int device_id) : device_id_{device_id}, drm_fd_{-1}, min_picture_width_{64}, min_picture_height_{64},
     max_picture_width_{4096}, max_picture_height_{4096}, supports_modifiers_{false}, va_display_{0}, va_config_attrib_{{}}, va_config_id_{0}, va_profile_{VAProfileJPEGBaseline},
-    vaapi_mem_pool_(std::make_unique<RocJpegVaapiMemoryPool>()), current_vcn_jpeg_spec_{0}, va_picture_parameter_buf_id_{0}, va_quantization_matrix_buf_id_{0}, va_huffmantable_buf_id_{0},
+    vaapi_mem_pool_(std::make_unique<RocJpegVaapiMemoryPool>()), current_vcn_jpeg_spec_{}, va_picture_parameter_buf_id_{0}, va_quantization_matrix_buf_id_{0}, va_huffmantable_buf_id_{0},
     va_slice_param_buf_id_{0}, va_slice_data_buf_id_{0} {};
 
 /**
@@ -344,12 +344,11 @@ RocJpegVappiDecoder::~RocJpegVappiDecoder() {
  * and other necessary parameters. It also sets up the VAAPI display and creates the decoder configuration.
  *
  * @param device_name The name of the device.
- * @param gcn_arch_name The name of the GCN architecture.
  * @param device_id The ID of the device.
  * @param gpu_uuid The UUID of the GPU.
  * @return The status of the initialization process.
  */
-RocJpegStatus RocJpegVappiDecoder::InitializeDecoder(std::string device_name, std::string gcn_arch_name, int device_id, std::string& gpu_uuid) {
+RocJpegStatus RocJpegVappiDecoder::InitializeDecoder(std::string device_name, int device_id, std::string& gpu_uuid) {
     device_id_ = device_id;
     std::vector<int> visible_devices;
     GetVisibleDevices(visible_devices);
@@ -788,14 +787,14 @@ RocJpegStatus RocJpegVappiDecoder::SubmitDecodeBatched(JpegStreamParameters *jpe
             CHECK_VAAPI(vaCreateSurfaces(va_display_, surface_format, key.width, key.height, mem_pool_entry.va_surface_ids.data(), mem_pool_entry.va_surface_ids.size(), surface_attribs.data(), supports_modifiers_ ? 2 : 1));
             mem_pool_entry.image_width = key.width;
             mem_pool_entry.image_height = key.height;
-            for (int i = 0; i < mem_pool_entry.va_surface_ids.size(); i++) {
+            for (size_t i = 0; i < mem_pool_entry.va_surface_ids.size(); i++) {
                 surface_ids[indices[i]] = mem_pool_entry.va_surface_ids[i];
             }
             mem_pool_entry.hip_interops.resize(indices.size(), HipInteropDeviceMem());
             mem_pool_entry.entry_status = kBusy;
             CHECK_ROCJPEG(vaapi_mem_pool_->AddPoolEntry(key.pixel_format, mem_pool_entry));
         } else {
-            for (int i = 0; i < mem_pool_entry.va_surface_ids.size(); i++) {
+            for (size_t i = 0; i < mem_pool_entry.va_surface_ids.size(); i++) {
                 surface_ids[indices[i]] = mem_pool_entry.va_surface_ids[i];
             }
         }

src/rocjpeg_vaapi_decoder.cpp

@@ -277,12 +277,11 @@ class RocJpegVappiDecoder {
     /**
      * @brief Initializes the decoder with the specified device, GCN architecture, and device ID.
      * @param device_name The name of the device.
-     * @param gcn_arch_name The name of the GCN architecture.
      * @param device_id The ID of the device.
      * @param gpu_uuid The UUID of the GPU.
      * @return The status of the initialization.
      */
-    RocJpegStatus InitializeDecoder(std::string device_name, std::string gcn_arch_name, int device_id, std::string& gpu_uuid);
+    RocJpegStatus InitializeDecoder(std::string device_name, int device_id, std::string& gpu_uuid);
 
     /**
      * @brief Submits a JPEG stream for decoding.