Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OMPIRBuilder] Init default kernel max-threads with -1 #218

Open
wants to merge 1 commit into
base: amd-trunk-dev
Choose a base branch
from
Open

[OMPIRBuilder] Init default kernel max-threads with -1 #218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6238,13 +6238,7 @@ OpenMPIRBuilder::InsertPointTy OpenMPIRBuilder::createTargetInit(
if (Bounds.MinTeams > 1 || Bounds.MaxTeams.front() > 0)
writeTeamsForKernel(T, *Kernel, Bounds.MinTeams, Bounds.MaxTeams.front());

// If MaxThreads not set, select the maximum between the default workgroup
// size and the MinThreads value.
int32_t MaxThreadsValue = Bounds.MaxThreads.front();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was this value before the change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a function argument. My change was only to refactor these arguments into a structure. Here's a cleaned-up version of these changes, which I'm trying to upstream: llvm#116050.

if (MaxThreadsValue < 0)
MaxThreadsValue = std::max(
int32_t(getGridValue(T, Kernel).GV_Default_WG_Size), Bounds.MinThreads);

if (MaxThreadsValue > 0)
writeThreadBoundsForKernel(T, *Kernel, Bounds.MinThreads, MaxThreadsValue);

Expand Down