[OMPIRBuilder] Init default kernel max-threads with -1 #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes the initialization of the MaxThreads global value and related kernel attributes based on the default workgroup size of the target architecture whenever an explicit value is not specified by the user through `thread_limit` or `num_threads` clauses. Instead, leave these undefined cases represented as a -1 value.
doru1004
reviewed
Dec 2, 2024
| @@ -6238,13 +6238,7 @@ OpenMPIRBuilder::InsertPointTy OpenMPIRBuilder::createTargetInit( | |||
| if (Bounds.MinTeams > 1 || Bounds.MaxTeams.front() > 0) | |||
| writeTeamsForKernel(T, *Kernel, Bounds.MinTeams, Bounds.MaxTeams.front()); | |||
|
|
|||
| // If MaxThreads not set, select the maximum between the default workgroup | |||
| // size and the MinThreads value. | |||
| int32_t MaxThreadsValue = Bounds.MaxThreads.front(); | |||
There was a problem hiding this comment.
What was this value before the change?
There was a problem hiding this comment.
It was a function argument. My change was only to refactor these arguments into a structure. Here's a cleaned-up version of these changes, which I'm trying to upstream: llvm#116050.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the initialization of the MaxThreads global value and related kernel attributes based on the default workgroup size of the target architecture whenever an explicit value is not specified by the user through
thread_limitornum_threadsclauses.Instead, leave these undefined cases represented as a -1 value.