Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues in helm chart #19

Open
boniek83 opened this issue May 5, 2021 · 1 comment
Open

Issues in helm chart #19

boniek83 opened this issue May 5, 2021 · 1 comment

Comments

@boniek83
Copy link

boniek83 commented May 5, 2021

Helm Chart version: 0.0.2
By DaemonSet I mean k8s-device-plugin DS.
DaemonSet should only create pods on nodes that have AMD hardware (should have and respect node_selector value from default values file -it doesn't at this time)
DaemonSet should have resources section (to limit resource usage)
DaemonSet should have priorityClassName: system-node-critical set (annotation is deprecated: https://github.com/kubernetes/website/commit/315c716774af079afa0c0479ff4513549c48a5e9/)
It would be better (although not critical as long as it can be overridden) if default node_selector was compatible with how NVidias bundled NFD behaves (for clusters with mixed GPUs) and have default value of:
feature.node.kubernetes.io/pci-1002.present=true
Using latest tag for labeller is bad idea - this is not reproducible.

@julian3xl
Copy link

I've created a pull request to fix this issue #29 that I'm suffering too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants