add ld-memory #229
Open
add ld-memory #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
approved these changes
May 31, 2023
|
bors merge |
bors bot
added a commit
that referenced
this pull request
May 31, 2023
229: add ld-memory r=kaspar030 a=kaspar030 This adds [ld-memory](https://github.com/kaspar030/ld-memory), a utility I wrote that creates GNU ld MEMORY sections from command line parameters. Needed for RIOT-OS/RIOT#19692. (adds ~800kB to the image) Co-authored-by: Kaspar Schleiser <[email protected]>
|
Build failed:
|
|
bors merge |
bors bot
added a commit
that referenced
this pull request
May 31, 2023
229: add ld-memory r=kaspar030 a=kaspar030 This adds [ld-memory](https://github.com/kaspar030/ld-memory), a utility I wrote that creates GNU ld MEMORY sections from command line parameters. Needed for RIOT-OS/RIOT#19692. (adds ~800kB to the image) Co-authored-by: Kaspar Schleiser <[email protected]>
|
Build failed:
|
|
@chrysn could you take a look here? seems like an unrelated Rust build error. |
|
|
(Why does the pull request "build" succeed?) |
|
this is the build issue |
|
Since this seems to be relatively reliable in reproducing the issue in RIOT-OS/RIOT#19714, would this help: diff --git a/makefiles/cargo-targets.inc.mk b/makefiles/cargo-targets.inc.mk
index 118cb83f7a..b23e8f6990 100644
--- a/makefiles/cargo-targets.inc.mk
+++ b/makefiles/cargo-targets.inc.mk
@@ -17,6 +17,7 @@ ifneq (,$(filter shell_democommands,$(USEMODULE)))
CARGO_OPTIONS += --features rust_riotmodules/riot-module-shell-democommands
endif
+.PHONY: $(CARGO_COMPILE_COMMANDS)
# This is duplicating the compile-commands rule because unlike in the use case
# when a $(RIOTBASE)/compile_commands.json is built, we *want* this to be
# per-board and per-application. (The large mechanisms are shared anyway).
@@ -40,7 +41,6 @@ $(CARGO_COMPILE_COMMANDS): $(BUILDDEPS)
-e 's/"riscv-none-embed"/"riscv32"/g' \
| $(LAZYSPONGE) $@
-
$(CARGO_LIB): $(RIOTBUILD_CONFIG_HEADER_C) $(BUILDDEPS) $(CARGO_COMPILE_COMMANDS) FORCE
$(Q)command -v cargo >/dev/null || ($(COLOR_ECHO) \
'$(COLOR_RED)Error: `cargo` command missing to build Rust modules.$(COLOR_RESET) Please install as described on <https://doc.riot-os.org/using-rust.html>.' ;\? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds ld-memory, a utility I wrote that creates GNU ld MEMORY sections from command line parameters.
Needed for RIOT-OS/RIOT#19692.
(adds ~800kB to the image)