Build extra riotdocker variant that includes nightly Rust #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrysn
force-pushed
the
riotbuild-rustnightly
branch
from
b92cf73 to
1480bea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #214 is merged (which, on its own, is not blocked any more), users who used riotdocker but also needed nightly features are in a bit of a pickle: There is no image any more with which they can just dockerbuild their applications in.
As this is not part of the critical CI tests, and the features this'd be used with are usually rather mature, I see no immediate need to pin the nightly version (which also means that, if we want to go this way, I may occasionally press the "master: re-run" button as the need arises).
I'm not 100% sure the tests that are added for this part of the GitHub actions really take -- I'm still investigating whether CARGO_CHANNEL is correctly passed through run-in-docker (but maybe that's unwarranted anyway because RIOT-OS/RIOT#18840 is a next step and would remove that variable altogether in favor of just using cargo's mechanisms, now that regular RIOT tests don't need to interfere with it any more).
Due disclaimer / more precise motivation: I expect to be the next user of these myself. There are upcoming abstractions in riot-wrappers that'd depend on nightly-only crates. While such features would not be covered by what is tested when RIOT's own riot-wrappers version is updated (for RIOT's tests are built on riotbuild, and with stable only, so the relevant features of riot-wrappers would just not be enabled). But riot-wrappers itself runs its tests (esp. native) on GitHub actions, and for these it'd be quite handy to have a riotdocker image with nightly available.
As for reviewing, the biggest question is whether we want to have this built and maintained in here. I think it fits, especially as it can re-use all the established secrets and uploading infrastructure, and because it ensures that the images are in sync with the base image (so that whoever switches from stable to nightly just needs to download a small Docker delta image).