Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rationalise configuration modifiable at run-time #3442

Open
jacopo-chevallard opened this issue Oct 31, 2024 — with Linear · 1 comment
Open

Rationalise configuration modifiable at run-time #3442

jacopo-chevallard opened this issue Oct 31, 2024 — with Linear · 1 comment
Assignees
@jacopo-chevallard
Labels
area: backend Related to backend functionality or under the /backend directory

Comments

@jacopo-chevallard Linear
Copy link
Collaborator

We should refactor the way we deal with the initial (user-provided) configuration of the workflow nodes and the modification of some of the configuration parameters at run-time, for instance in the methods get_reranker and filter_chunks_by_relevance.

We currently use pop from kwargs to update the default parameters read from the input and saved in the different config classes
@linear Linear
Copy link

linear bot commented Oct 31, 2024

CORE-273 Rationalise configuration modifiable at run-time

@dosubot dosubot bot added the area: backend Related to backend functionality or under the /backend directory label Oct 31, 2024
@jacopo-chevallard jacopo-chevallard self-assigned this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacopo-chevallard jacopo-chevallard

Labels
area: backend Related to backend functionality or under the /backend directory
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jacopo-chevallard