Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Taking a Ton of Time Rendering Crash Logs #350

Open
sylv256 opened this issue Aug 19, 2023 · 1 comment
Open

Stop Taking a Ton of Time Rendering Crash Logs #350

sylv256 opened this issue Aug 19, 2023 · 1 comment

Comments

@sylv256
Copy link

sylv256 commented Aug 19, 2023

Quilt will sometimes refuse to spit out a crash log because it needs to calculate the hash of every single mod (see: BlanketCon '23 with >400 mods).
This is a profile from unascribed where she made a mixin to disable a lag-inducing feature in Create. However, this caused a crash, but Quilt refuses to produce a crash log. In total, it took ~30 seconds.
image
Sorry for the late edit. I accidentally hit the enter key. Work in progress!

@AlexIIL
Copy link
Contributor

AlexIIL commented Aug 19, 2023

Okay, so:

  1. This should probably re-use the hash value calculated during cache building.
  2. This looks like it calculates the hash for the containing file for every included file, which is obviously unnecessary (this won't be a problem if we re-use the transform cache hash though).

AlexIIL added a commit that referenced this issue Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants