Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point Entities build as QodotSpatial instead of chosen Node Class #167

Open
DeerTears opened this issue Feb 16, 2023 · 0 comments
Open

Point Entities build as QodotSpatial instead of chosen Node Class #167

DeerTears opened this issue Feb 16, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@DeerTears
Copy link
Member

Current behaviour

Any point class builds as a QodotSpatial node. Node Class is ignored. This is unlike Solid Classes which do read from Node Class to determine their node type.

This bug is even acknowledged in the example Light class which spawns a light child. It's a hack, rather than using the Node Class field as intended.

Expected behaviour

Just like a solid class, the node name in Node Class is what QodotMap should build to represent that entity. There's no need to spawn the correct child node if the root node is the correct type. Scripts should attach as normal, properties should fill as normal.

It would also be nice to upgrade the example light entity to work with this change once I'm done making it.

Anticipated breaking changes

Some people's point classes will change node type if there is something entered in the Node Class field. For all cases, clearing the Node Class string should fix the node type change. Point classes with scene files shouldn't be affected.

In Closing

Now I know why point classes have been so hard to document 😅 scene file still works as intended so it's been the lead workaround for this bug. Credit to @RhapsodyInGeek for finding this.

@DeerTears DeerTears self-assigned this Feb 16, 2023
@DeerTears DeerTears added the bug Something isn't working label Feb 16, 2023
@DeerTears DeerTears changed the title Bug: Point Entities builds as QodotSpatial instead of chosen Node Class Point Entities build as QodotSpatial instead of chosen Node Class Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant