Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement condensation graph generation #1337

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kazuki0824
Copy link
Contributor

@kazuki0824 kazuki0824 commented Dec 8, 2024

This pull request adds functionality to generate condensation graphs. The Rust implementation is copied and slightly modified from https://github.com/petgraph/petgraph because the original petgraph implementation cannot be applied as it is. Condensation graphs represent strongly connected components of a directed graph as single nodes. The update includes a new implementation and its test to support this feature.

  • I ran rustfmt locally
  • I have added the tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@kazuki0824 kazuki0824 force-pushed the feat/generate_condensation_graph branch from eed8af1 to fada9a1 Compare December 8, 2024 17:38
@coveralls
Copy link

coveralls commented Dec 9, 2024

Pull Request Test Coverage Report for Build 12451773226

Details

  • 58 of 64 (90.63%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 95.807%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/connectivity/mod.rs 57 63 90.48%
Files with Coverage Reduction New Missed Lines %
rustworkx-core/src/generators/random_graph.rs 2 85.04%
Totals Coverage Status
Change from base Build 12365971131: -0.03%
Covered Lines: 18417
Relevant Lines: 19223

💛 - Coveralls

@kazuki0824 kazuki0824 marked this pull request as ready for review December 15, 2024 08:01
@kazuki0824 kazuki0824 force-pushed the feat/generate_condensation_graph branch from 8754ccd to 9c026b2 Compare December 15, 2024 08:06
@kazuki0824
Copy link
Contributor Author

@IvanIsCoding can anyone review this code?

@kazuki0824 kazuki0824 force-pushed the feat/generate_condensation_graph branch from 57dc3fe to 5045623 Compare December 22, 2024 06:03
@IvanIsCoding
Copy link
Collaborator

@IvanIsCoding can anyone review this code?

Sorry I haven’t acknowledged the PR. I haven’t had time to review it.

I will do the review after Christmas, it might still make the cut for rustworkx 0.16.

@kazuki0824
Copy link
Contributor Author

@IvanIsCoding can anyone review this code?

Sorry I haven’t acknowledged the PR. I haven’t had time to review it.

I will do the review after Christmas, it might still make the cut for rustworkx 0.16.

Thank you for your quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants