Proposal: Benchmarks for phase space points #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szabo137
force-pushed
the
benchmark_phase_space
branch
from
a9d6c02
to
19ab1e2
Compare
added 2 commits
May 13, 2024 11:31
Comment on lines
+28
to
+29
| QEDprocesses.incoming_particles(proc::TestProcess) = proc.incoming_particles | ||
| QEDprocesses.outgoing_particles(proc::TestProcess) = proc.outgoing_particles |
There was a problem hiding this comment.
According to the interface description, these should return tuples, but currently they return Vectors, which is bad because it's type unstable.
There was a problem hiding this comment.
The same problem exists in the TestImplementation of the tests themselves. I changed this in #63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to include benchmarks of the phase space point functionality to QEDprocesses.jl. The implementation is not very sophisticated, but it shows to some extent the current performance status and helps keep track of improvements.
Since this does not change the main code and is rather self-contained, this could be added to represent a blueprint for future benchmarks of other parts of QEDprocesses.jl (or even other packages within QED.jl)