Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions should not use PhaseSpacePoint directly #86

Open
AntonReinhard opened this issue Jun 27, 2024 · 0 comments
Open

Functions should not use PhaseSpacePoint directly #86

AntonReinhard opened this issue Jun 27, 2024 · 0 comments
Labels
05 - Enhancement Improvements of existing code good first issue Good for newcomers

Comments

@AntonReinhard
Copy link
Member

This is not urgent, but the implementations of the interface functions such as _matrix_element currently use the concrete type PhaseSpacePoint from QEDcore, but should rather use the AbstractPhaseSpacePoint from QEDbase and its interface functions.

Related to this, they should not use the function _momentum_type since it is not part of the interface. Alternatively, we could make it part of the interface. However, since the momentum element type is not part of the AbstractPhaseSpacePoint's type parameters, I'm not sure this would make sense.

@AntonReinhard AntonReinhard added the 05 - Enhancement Improvements of existing code label Jun 27, 2024
@AntonReinhard AntonReinhard added the good first issue Good for newcomers label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
05 - Enhancement Improvements of existing code good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant