You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is not urgent, but the implementations of the interface functions such as _matrix_element currently use the concrete type PhaseSpacePoint from QEDcore, but should rather use the AbstractPhaseSpacePoint from QEDbase and its interface functions.
Related to this, they should not use the function _momentum_type since it is not part of the interface. Alternatively, we could make it part of the interface. However, since the momentum element type is not part of the AbstractPhaseSpacePoint's type parameters, I'm not sure this would make sense.
The text was updated successfully, but these errors were encountered:
This is not urgent, but the implementations of the interface functions such as
_matrix_element
currently use the concrete typePhaseSpacePoint
from QEDcore, but should rather use theAbstractPhaseSpacePoint
from QEDbase and its interface functions.Related to this, they should not use the function
_momentum_type
since it is not part of the interface. Alternatively, we could make it part of the interface. However, since the momentum element type is not part of theAbstractPhaseSpacePoint
's type parameters, I'm not sure this would make sense.The text was updated successfully, but these errors were encountered: