Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export _momentum_type #31

Open
szabo137 opened this issue Jun 27, 2024 · 1 comment
Open

Export _momentum_type #31

szabo137 opened this issue Jun 27, 2024 · 1 comment
Labels
06 - Feature-request Missing a feature or functionality good first issue Good for newcomers

Comments

@szabo137
Copy link
Member

The function _momentum_type is sometimes used to get the scalar element type, e.g. to produce the correctly typed nil using zero. Therefore, it would be good to make it publicly available.

QEDcore.jl/src/phase_spaces/utility.jl

Line 118 in 56f2444

@inline function _momentum_type(

@szabo137 szabo137 added 06 - Feature-request Missing a feature or functionality good first issue Good for newcomers labels Jun 27, 2024
@szabo137
Copy link
Member Author

One could also make momentum_type an interface function for AbstractPhaseSpacePoints.

Alternatively, one could require the implementation of Base.eltype for subtypes of AbstractPhaseSpacePoints, i.e. making this part of the interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
06 - Feature-request Missing a feature or functionality good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@szabo137