Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linter - Dashboard #95

Open
upkarlidder opened this issue Jun 2, 2021 · 2 comments
Open

Add linter - Dashboard #95

upkarlidder opened this issue Jun 2, 2021 · 2 comments
Assignees
@krook @upkarlidder @TaeBlack @Aquijada52
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@upkarlidder
Copy link
Member

upkarlidder commented Jun 2, 2021 •
edited
Loading

Add linter as a GitHub action. This repo has three components

  1. API - Python
  2. Dashboard - React.js
  3. Auth - Node.js

Additional linters:

  • Dockerfile

We might need three separate linters. Team to research.
@krook
Copy link
Member

krook commented Jul 27, 2021

In place are prettier for the Node.js and React apps. black is in place for the Python/Flask app.

@krook krook added enhancement New feature or request good first issue Good for newcomers labels Jul 27, 2021
@krook
Copy link
Member

krook commented Oct 21, 2021

This is still a good first issue. Check out package.json for the linter commands that can be extracted into GitHub Actions based on what's in the Sensor Simulator and other repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krook krook

@upkarlidder upkarlidder

@TaeBlack TaeBlack

@Aquijada52 Aquijada52

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@krook @upkarlidder @TaeBlack @Aquijada52