Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard ReadMe Review #104

Open
Aquijada52 opened this issue Jul 8, 2021 · 1 comment
Open

Dashboard ReadMe Review #104

Aquijada52 opened this issue Jul 8, 2021 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@Aquijada52
Copy link
Member

No description provided.

@Aquijada52 Aquijada52 added the documentation Improvements or additions to documentation label Jul 9, 2021
@upkarlidder
Copy link
Member

The README right now assumes the reader is an intermediate developer and has a good understanding of how the project works. I propose adding more details to make the README more beginner-friendly. @krook feedback welcome.

  1. There are no instructions on adding APP ID credentials to https://github.com/Pyrrha-Platform/Pyrrha-Dashboard/blob/main/pyrrha-dashboard/api-auth/vcap-local.template.json. Copy the instructions from OpenEEW repo to here.
  2. Add details to generate service credentials for App ID in the readme
  3. All file routes should be relative to the README file. So for example /api-main/.env.example should be pyrrha-dashboard/api-main/.env.example. Alternatively, the readme should ask the user to change to the pyrrha-dashboard directory.
  4. This assumes everything is running in a local development environment on a single localhost, if you are deploying the services separately, update the proxy and CORS settings in src/setupProxy.js: explain what the proxy does and why the user needs to update it when running each service separately.
  5. Run yarn install to pull in all required packages. where does the user run this command? This needs to be run in each of the directories; pyrrha-dashboard, and pyrrha-dashboard/api-auth
  6. There are a lot of steps in the following instruction:
- Start the back-end Flask API services with the command in the `package.json` file set of NPM scripts, in this case `start-main-api`. This will launch a server on port 5000, proxied through the front end port 3000 for the `/api-main/v1/` path. If you 
- haven't yet installed a Flask environment, run `python3 -m venv venv; . venv/bin/activate; pip install -r requirements.txt`. 

Divide into the following (need to test):

  • cd into pyrrha-dashboard/api-main
  • create the python virtual environment python3 -m venv venv
  • activate the virtual environment venv/bin/activate
  • install dependencies: pip install -r requirements.txt
  • cd out to the main directory
  • run yarn run start-main-api
  1. The other steps can also be simplified similarly.
  2. The following sections are not being used. I propose we remove from the readme and clean the code up later:
- Events (`/events`) - List, edit, add, delete events.
- Devices (`/devices`) - List, edit, add, delete devices.
- Firefighters (`/firefighters`) - List, edit, add, delete firefighters.
- Profile (`/profile`) - Show's the read only view of the logged in user.
  1. At the end, link to docker-compose file in the main Pyrrha directory as another way to get the whole system up at once.

@krook krook added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

4 participants