You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The pyo3_built macro adds an import bound for email.utils to parse a string date into a datetime, which seems really unnecessary to me. It adds a significant amount of import time to our library.
Even parsing the date in Rust and importing datetime to generate a Datetime object directly (while significantly better) seems unnecessary, although that would be a backwards-compatible.
My suggestion would be to replace the info-time field with a ISO 8601 timestamp string that we generate on the Rust side. Then if a user really wants a Datetime they can just datetime.datetime.fromisoformat the string.
The text was updated successfully, but these errors were encountered:
The
pyo3_built
macro adds an import bound foremail.utils
to parse a string date into a datetime, which seems really unnecessary to me. It adds a significant amount of import time to our library.Even parsing the date in Rust and importing
datetime
to generate aDatetime
object directly (while significantly better) seems unnecessary, although that would be a backwards-compatible.My suggestion would be to replace the
info-time
field with a ISO 8601 timestamp string that we generate on the Rust side. Then if a user really wants aDatetime
they can justdatetime.datetime.fromisoformat
the string.The text was updated successfully, but these errors were encountered: