b042: ignore overloaded init, ignore if str+pickle dunder, improve README #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rove README blurb
jakkdl
changed the title
Closed
kurtmckee
suggested changes
Nov 25, 2025
Contributor
kurtmckee
left a comment
kurtmckee
left a comment
There was a problem hiding this comment.
Thanks for your work on this!
Comment on lines
+53
to
+58
| # ignore overloaded __init__ | ||
| class MyException(Exception): | ||
| @overload | ||
| def __init__(self, x: int): ... | ||
| @overload | ||
| def __init__(self, x: float): ... |
Contributor
There was a problem hiding this comment.
I've tested this branch and confirmed that it resolves the false positive I posted in #525.
Co-authored-by: Kurt McKee <[email protected]>
cooperlees
approved these changes
Nov 26, 2025
Collaborator
cooperlees
left a comment
cooperlees
left a comment
There was a problem hiding this comment.
Many thanks @jakkdl for the improvements !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #525
it also silences the error if it detects
__str__and any of the pickle dunders.please have opinions on the README blurb!