Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set target path to bin/ folder for cleaner builds #335

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ryuukk
Copy link
Contributor

@ryuukk ryuukk commented Aug 10, 2023

I haven't tested the release.sh and release.bat yet

@WebFreak001
Copy link
Member

tests failing, this also needs changes in code-d and a migration plan for old code-d versions

@ryuukk
Copy link
Contributor Author

ryuukk commented Aug 10, 2023

Oh, it might not be worth it to change then

@WebFreak001
Copy link
Member

currently I don't think it's a high priority, especially on unix it's just serve-d as the only file and on windows there are only 3 copied DLLs, which I'm not sure if they are even all needed anymore, since I changed to Win32 inet API instead of curl.

I don't think the app would grow in files in the future, but now might still be a better time to put it in a separate folder rather than later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants