-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plug support of CCDB in serve-d #271
base: master
Are you sure you want to change the base?
Conversation
2daa406
to
3bfd9c0
Compare
Quite many commits. Don't hesitate to ask to squash. |
yeah sorry about the delay, could you also auto-format your ccdb files? There seems to be mixed spaces and tabs occasionally. |
I rebased on master and squashed everything in a single commit. |
commit 94f0291 is making The crash happens with big project as well as with minimal example: https://github.com/rtbo/simple-meson-d If I rebase this PR on the commit just before 94f0291, there is no more crash. EDIT: not related to this PR and fixed by #321 |
9dace45
to
dd44d10
Compare
two new settings are added: - d.ccdbPath: user specified path to `compile_commands.json` to consider as input - d.enableCcdbLinting: whether to activate linting of CCDB files Linting works by actually compiling the file using command specified in CCDB and scanning for compiler error.
indicate to user that the diagnostics are running
- makes `adjustArgs` lazy mutation more convenient
drive letter is now always lower case
was [0] before but was changed a while ago in another fix. We don't _really_ care yet where it is, but probably should in the future.
WIP to enable CCDB in serve-d:
d.ccdbPath
for the path tocompile_commands.json
d.ccdbPath
is set (inonConfigChange
event)Works already well like this.
I'd like to go further: running the command associated with the file to parse for diagnostics (instead of DScanner).
In ideal world, the import paths, versions etc. would not be a global list for the workspace, but a different set for each file.
For this I need one dcd-server instance per open file right?
For import paths it would not matter much, but for versions we can imagine at some point to grey out code related to unset versions.
Works with Pure-D/code-d#436