-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite ide-d using serve-d #34
Conversation
@WebFreak001 So, this now uses serve-d directly to spawn the language server. However, when I use this on project, I get all sorts of errors. Does https://github.com/aminya/atomize-d/blob/update/src/atomize-d.ts#L24 To install:
Open any D project
|
So, what is the solution? I am not using workspace-d. I am just using serve-d directly. |
I think I fixed the spawn error by coping serve-d exe into |
workspace-d is used by serve-d, which is why you are seeing the error. Putting the DCD exe next to serve-d will always work because that's the first path serve-d/workspace-d search for the exe, otherwise the configurations ( In your last error it somehow crashes fatally (segfault or something), I need to investigate that, but can only do so on linux. If you want you could try compiling serve-d from source in debug mode (just |
Some of the errors are gone (e.g. these). I had to copy the dll files into the code-d folder! 🤦♂️ |
can you share how atom does the initialization procedure? (initialize, initialized & if it sends any configurations afterwards) functionality might be there, just not actually resolving to anything. |
@WebFreak001 Could you please give me write access to this repository? I want to merge and register it. I would like to change the package name to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, gave you access to the repo. Check the comments here as well.
@@ -297,9 +288,6 @@ class ${1:MyException} : ${4:Exception} { | |||
"with": | |||
"prefix": "with" | |||
"body": "with" | |||
"scope": | |||
"prefix": "scope" | |||
"body": "scope" | |||
"asm": | |||
"prefix": "asm" | |||
"body": "asm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the snippets can probably completely be removed, they are handled by workspace-d/serve-d now. (needs --provides context-snippets
as startup argument)
In code-d there are snippets for diet files which may be useful though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to test if the snippet provider works. For now, I think this does the work 🤔
async startServerProcess(projectPath: string) { | ||
const serveDPath = await installServeD() | ||
|
||
const serveD = super.spawn(serveDPath, [], { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is localization support for UI messages in serve-d. If atom provides the language in 2 letter format (ie. en
or en-GB
), then you can pass it using ["--lang", language]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not so sure about that. I need to ask.
Complete overhaul
Fixes #32
Fixes #28
Closes #24