Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requests upgrade ok? #162

Open
davidread opened this issue Aug 7, 2015 · 4 comments
Open

requests upgrade ok? #162

davidread opened this issue Aug 7, 2015 · 4 comments

Comments

@davidread
Copy link

The requirements.txt specifies "requests==1.1.0" and on core CKAN we're looking to upgrade the requests version in the next CKAN release. We just want to make you aware so you can check compatibility - we've noticed minor things change, like the type of response.headers is not a dict, but a dict-like object. We're looking at requests version 2.3.0 or 2.7.0.

@davidread
Copy link
Author

BTW the related ckan discussion is here: ckan/ckan#2470

@drmalex07
Copy link
Member

Thanks @davidread.
Currently, the ckanext-publicamundi extension is only compatible with CKAN 2.2 but, of course, we want to keep pace with new CKAN releases (#97). So i assume that porting our requests-depending code will be a part of this work.

@davidread
Copy link
Author

Ok, great, I'll leave this with you then. Feel free to close this issue or keep it open, as you wish.

@drmalex07
Copy link
Member

Ok, we' ll keep it open as long as #97 is open (since it contains it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants