From 944ab1eb75c2a5707abcc061f9af08faaac4b3f9 Mon Sep 17 00:00:00 2001
From: yippeeeyay <thelastblud@gmail.com>
Date: Sun, 12 Jan 2025 16:13:45 -0500
Subject: [PATCH] Sets require restart to false for a few core options for
 emuThree; adds description for Shader Accurate Mul

I noticed that most options that have 'requiresRestart: true' do not actually apply on restart. These changes should (in theory) fix upscaling not updating, cpu clock not updating, as well as some other core options. On Citra, most settings do not require a restart anyway, except for JIT.

This needs to be tested as I cannot build emuThree for myself.
---
 .../Core/PVEmuThreeCoreOptions.swift          | 20 +++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/Cores/emuThree/PVEmuThreeCore/Core/PVEmuThreeCoreOptions.swift b/Cores/emuThree/PVEmuThreeCore/Core/PVEmuThreeCoreOptions.swift
index a42d53869e..9b3c6a45a1 100644
--- a/Cores/emuThree/PVEmuThreeCore/Core/PVEmuThreeCoreOptions.swift
+++ b/Cores/emuThree/PVEmuThreeCore/Core/PVEmuThreeCoreOptions.swift
@@ -6,8 +6,8 @@ import PVCoreBridge
     
     static var resolutionOption: CoreOption {
         .enumeration(.init(title: "Resolution Upscaling",
-                           description: "(Requires Restart)",
-                           requiresRestart: true),
+                           description: nil,
+                           requiresRestart: false),
                      values: [
                         .init(title: "1X", description: "1X", value: 1),
                         .init(title: "2X", description: "2X", value: 2),
@@ -32,9 +32,9 @@ import PVCoreBridge
     }
     
     static var cpuClockOption: CoreOption {
-        .enumeration(.init(title: "CPU Clock",
-                           description: "(Requires Restart) Underclocking can increase performance but may cause the game to freeze. Overclocking may reduce in game lag but also might cause freezes",
-                           requiresRestart: true),
+        .enumeration(.init(title: "CPU Clock Speed",
+                           description: "Underclocking can increase performance but may cause the game to freeze. Overclocking may reduce in game lag but also might cause freezes",
+                           requiresRestart: false),
                      values: [
                         .init(title: "10%", description: "10%", value: 10),
                         .init(title: "20%", description: "20%", value: 20),
@@ -65,7 +65,7 @@ import PVCoreBridge
         .bool(.init(
             title: "Enable Logging",
             description: "May affect performance",
-            requiresRestart: true),
+            requiresRestart: false),
               defaultValue: false)
     }
     
@@ -73,7 +73,7 @@ import PVCoreBridge
         .bool(.init(
             title: "Enable New 3DS",
             description: nil,
-            requiresRestart: true),
+            requiresRestart: false),
               defaultValue: true)
     }
     
@@ -91,7 +91,7 @@ import PVCoreBridge
         .bool(.init(
             title: "Enable Async Shader Compilation",
             description: nil,
-            requiresRestart: true),
+            requiresRestart: false),
               defaultValue: false)
     }
     
@@ -127,8 +127,8 @@ import PVCoreBridge
     static var enableShaderAccurateMulOption: CoreOption {
         .bool(.init(
             title: "Enable Shader Accurate Mul",
-            description: nil,
-            requiresRestart: true),
+            description: "Some games require this to be enabled to render properly, but slightly reduces performance",
+            requiresRestart: false),
               defaultValue: true)
     }