Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal Relative Links broken in Binder version of pages #311

Open
jukent opened this issue Jul 18, 2022 · 1 comment
Open

Internal Relative Links broken in Binder version of pages #311

jukent opened this issue Jul 18, 2022 · 1 comment
Labels
bug Issues that present a reasonable conviction there is a reproducible bug. infrastructure Infrastructure related issue

Comments

@jukent
Copy link
Contributor

jukent commented Jul 18, 2022

What happened: Relative local links don't work in the Binder version of each foundations page. This was noticed by Lily Kailyn

What you expected to happen: Links to work

Minimal Complete Verifiable Example: Replace this links with absolute paths

@jukent jukent added the bug Issues that present a reasonable conviction there is a reproducible bug. label Jul 18, 2022
@jukent jukent added infrastructure Infrastructure related issue medium priority labels Oct 5, 2022
@brian-rose
Copy link
Member

This is an interesting question at the edge of what we're asking the Binder to do. Should the entire book be navigable from within the Binder so that links between different notebooks will open live notebooks on the Binder?

Or should those links take you to the static page version of that notebook (preferably in a different browser tab so your Binder session stays open)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that present a reasonable conviction there is a reproducible bug. infrastructure Infrastructure related issue
Projects
Status: Backlog
Development

No branches or pull requests

3 participants