Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile to using cache layer #534

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

piggy2303
Copy link

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
optimize dockerfile so it can take advantage of cache layer to build docker image faster

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@piggy2303 piggy2303 marked this pull request as draft October 8, 2024 04:06
@piggy2303 piggy2303 marked this pull request as ready for review October 8, 2024 04:07
@thedarkjimmy
Copy link

good job

@wawa0210
Copy link
Member

@piggy2303 Thanks your contribution, before approve,you need to fix the DCO issue

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 27.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

dependabot bot and others added 4 commits October 12, 2024 11:04
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: piggy2303 <[email protected]>
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.8.0 to 6.9.0.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@v6.8.0...v6.9.0)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: piggy2303 <[email protected]>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.3 to 4.4.0.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3.1.3...v4.4.0)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: piggy2303 <[email protected]>
Signed-off-by: jimmy <[email protected]>
Signed-off-by: piggy2303 <[email protected]>
@piggy2303 piggy2303 force-pushed the dockerfile_optimize branch 3 times, most recently from 9564ffd to db78048 Compare October 12, 2024 05:03
@piggy2303 piggy2303 force-pushed the dockerfile_optimize branch 3 times, most recently from d01def6 to 8fa0823 Compare October 12, 2024 08:38
piggy2303 and others added 2 commits October 12, 2024 15:39
…sers.noreply.github.com>

Update Dockerfile 
Signed-off-by: TuanAnh Nguyen <[email protected]>
Bumps ubuntu from 20.04 to 24.04.

---
updated-dependencies:
- dependency-name: ubuntu
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@wawa0210
Copy link
Member

@piggy2303 Can you rebase your commits ?

dependabot bot and others added 4 commits October 14, 2024 10:28
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.3 to 4.4.0.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3.1.3...v4.4.0)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: piggy2303 <[email protected]>
Signed-off-by: jimmy <[email protected]>
Signed-off-by: piggy2303 <[email protected]>
…sers.noreply.github.com>

Update Dockerfile 
Signed-off-by: TuanAnh Nguyen <[email protected]>
@wawa0210
Copy link
Member

@piggy2303 Hey, you need to rebase this pr to single commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants