Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this maintained? #40

Open
flexchar opened this issue Feb 15, 2021 · 16 comments
Open

Is this maintained? #40

flexchar opened this issue Feb 15, 2021 · 16 comments

Comments

@flexchar
Copy link

flexchar commented Feb 15, 2021

I am working with a company whose exploring installing PrintNode on its facilities. PHP is the language in use. The website does a good presentation and gives positive impression. It's obviously a paid product. However a this repository seems to not be maintained anymore. This is not acceptable for a paid product.

So how is it?

@krizzdev
Copy link

We use this package since several years but are now very limited with some features. The most annoying thing is to set a given timeout value manually because it is hard coded int the curl request.

There is also a PR which isn't merged from last year: #32

@flexchar
Copy link
Author

flexchar commented Feb 19, 2021

I contacted support as the package was not working for newly created account. Turns out API has changed and is only backwards compatible to old accounts. I have made pull request fixing the issue - #41. Hopefully they merge yours & mine soon.

@Nek-
Copy link

Nek- commented Mar 15, 2021

There's no stable version. Last commits break the API of the library. Bugs are not fixed. I believe that if somebody is motivated, this library should be fork.

@flexchar
Copy link
Author

Ahh, they mentioned they gonna at least fix the critical bug. :((

@Nek-
Copy link

Nek- commented Mar 15, 2021

The work 11 days ago consists mostly of removing the existing code, this will just break all our applications. Luckily they saved the master branch as "old master" so composer can still get the old (more recent ironically) code.

I'm not sure the situation is going any better here. 🙈

@shakethatweight-simon
Copy link

@Nek- I'm tempted to fork this, don't have much time to update the code, but with the branch renaming, I need old-master, but packagist hasn't been updated so I can't select "dev-old-master". By forking I could switch the branches back to the way they should be and start tagging version releases.

@Nek-
Copy link

Nek- commented Mar 16, 2021

@shakethatweight-simon you can specifically pick a commit, it works with composer and it's the best you can do I guess.

{
    "require": {
		"printnode/printnode-php": "dev-master#960acabca3c0d976bbd92bf0d6490a1fe5df7496"
    }
}

I'm sorry to hear you have trouble with the package but I'm not affiliated at all with PrintNode, I can only wish you good luck.

@krizzdev
Copy link

krizzdev commented Jun 1, 2021

Has anyone of you a maintained repository of the old-master ? Currently have the same issue because the namespaces changed in the new master branch

@shakethatweight-simon
Copy link

@krizzdev Looking at my composer.json it looks like we're using a fork I setup : https://github.com/shakethatweight-simon/PrintNode-PHP

@krizzdev
Copy link

krizzdev commented Jun 1, 2021

Thanks @shakethatweight-simon for your quick answer.
I just found https://github.com/rawilk/laravel-printing this package here. I think I will build on that

@shakethatweight-simon
Copy link

@krizzdev
Copy link

krizzdev commented Jun 1, 2021

You're right. But with 187 stars I think it's more supported and maybe the abstraction is handled better.
What I mean is that the chance is higher that laravel-printing will react quicker to fix/workaround an issue.

My whole application broke because printnode-php recommends using the dev-master branch and swapped it out in the last months.

@rawilk
Copy link

rawilk commented Feb 10, 2022

I'm the maintainer of laravel-printing, but I haven't really had a chance to do much work on it until now.

I personally use the 2.0@RC version in my own projects and it seems to work okay, but the Entity class they have isn't compatible with JsonSerializable, which obviously is a problem. I'm going to try and find a workaround for this, but if anyone knows any working forks or alternatives for using the printnode api, that'd be great too.

@rawilk
Copy link

rawilk commented Feb 15, 2022

For anyone interested, I've just tagged v3.0.0 of laravel-printing and it removes this package as a dependency entirely. I've written my own api wrapper for interacting with PrintNode's api.

@shakethatweight-simon
Copy link

For anyone interested, I've just tagged v3.0.0 of laravel-printing and it removes this package as a dependency entirely. I've written my own api wrapper for interacting with PrintNode's api.

We don't have any immediate plans to update this part of our project at the moment, but I have left a comment in our notes to review the printnode integration and investigate v3.0.0

@DjThossi
Copy link

What a shame for a paid product to give a shit about their SDKs. That's the best way of interaction with ANY API. And the easiest to onboard new customers. Oh and in the case of PrintNode, the easiest way to make money.

My recommendation to @PrintNodeLtd : open this project up and take someone from the community to support you with proper release cycles (tagging and such) and further PHP version support.

I'm working in a company which would even consider to fund this project IF it would be properly maintained. If more details required please let directly me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants